exceptions: cleaning up macros #35694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssawilk
force-pushed
the
macros2
branch
2 times, most recently
from
daaeb50
to
e6ab316
Compare
alyssawilk
force-pushed
the
macros2
branch
4 times, most recently
from
b26f139
to
811beca
Compare
Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk
requested review from
ggreenway,
yanavlasov,
zuercher,
mattklein123,
tyxia,
wbpcode,
RyanTheOptimist,
jmarantz and
soulxu
as code owners
zuercher
approved these changes
Sep 11, 2024
| @@ -217,7 +217,7 @@ TEST(HeaderParserTest, TestParse) { | |||
|
|
|||
| if (test_case.expected_exception_) { | |||
| EXPECT_FALSE(test_case.expected_output_); | |||
| EXPECT_THROW(THROW_IF_STATUS_NOT_OK(HeaderParser::configure(to_add), throw), EnvoyException); | |||
| EXPECT_THROW(THROW_IF_NOT_OK_REF(HeaderParser::configure(to_add).status()), EnvoyException); | |||
There was a problem hiding this comment.
nit: this one could just be EXPECT_FALSE(HeaderParser::configure(to_add).status().ok()) or similar. (I see we have an EXPECT_OK but not sure if there's an existing way to invert it.)
unicell
added a commit
to unicell/envoy
that referenced
this pull request
Sep 11, 2024
* upstream/main: (21 commits) Add a CPU utilization resource monitor for overload manager (envoyproxy#34713) jwks: Add UA string to headers (envoyproxy#35977) exceptions: cleaning up macros (envoyproxy#35694) coverage: ratcheting (envoyproxy#36058) runtime: load rtds bool correctly as true/false instead of 1/0 (envoyproxy#36044) Typo in documentation of http original_src filter (envoyproxy#36060) docs: updating meeting info (envoyproxy#36052) quic: removes more references to spdy::Http2HeaderBlock. (envoyproxy#36057) json: add null support to the streamer (envoyproxy#36051) json: make the streamer a template class (envoyproxy#36001) docs: Add `apt.envoyproxy.io` install information (envoyproxy#36050) ext_proc: elide redundant copy in ext_proc filter factory callback (envoyproxy#36015) build(deps): bump yarl from 1.11.0 to 1.11.1 in /tools/base (envoyproxy#36049) build(deps): bump multidict from 6.0.5 to 6.1.0 in /tools/base (envoyproxy#36048) quic: enable certificate compression/decompression (envoyproxy#35999) Geoip fix asan failure (envoyproxy#36043) mobile: Fix missing logging output in Swift integration tests (envoyproxy#36040) http: minor code clean up to the http filter manager (envoyproxy#36027) ci/example: Dont build/test the filter example in Envoy CI (envoyproxy#36038) ci/codeql: Fix build setup (envoyproxy#36021) ... Signed-off-by: Qiu Yu <[email protected]>
mum4k
added a commit
to mum4k/nighthawk
that referenced
this pull request
Sep 13, 2024
- synced `.bazelrc`, `tools/gen_compilation_database.py`, `tools/code_format/config.yaml` from Envoy's version. - no changes in `.bazelversion`, `ci/run_envoy_docker.sh`. - replaced macro `THROW_IF_STATUS_NOT_OK` with `THROW_IF_NOT_OK_REF` as per envoyproxy/envoy#35694. Signed-off-by: Jakub Sobon <[email protected]>
mum4k
added a commit
to envoyproxy/nighthawk
that referenced
this pull request
Sep 17, 2024
- synced `.bazelrc`, `tools/gen_compilation_database.py`, `tools/code_format/config.yaml` from Envoy's version. - no changes in `.bazelversion`, `ci/run_envoy_docker.sh`. - replaced macro `THROW_IF_STATUS_NOT_OK` with `THROW_IF_NOT_OK_REF` as per envoyproxy/envoy#35694. Signed-off-by: Jakub Sobon <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 19, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <[email protected]>
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Nov 21, 2024
Relates: envoyproxy/envoy#36187 Relates: envoyproxy/envoy#34815 Relates: envoyproxy/envoy#35694 Signed-off-by: Tam Mach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: low
Testing: existing tests
Docs Changes: n/a
Release Notes: n/a